A few leadsheet-related fixes #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vior as note tags with voice. I see this quite a bit in leadsheets where these are used to position chord changes within a melody note.
|
Huh. That test failure has nothing to do with this PR. |
…ved. Added missing opFrac().
gregchapman-dev
changed the title
|
A second fix: a missing opFrac call in OffsetHierarchyFilter that I ran into. |
mscuthbert
approved these changes
Jun 13, 2024
| self.voiceIndices.add(vIndex) | ||
| # it is a set, so no need to check if already there | ||
| # additional time < 1 sec per ten million ops. | ||
| for tagSearch in ('note', 'forward'): |
There was a problem hiding this comment.
Should we also be searching in <direction> tags? They're the only other thing that can contain a voice tag. But maybe unnecessary.
| @@ -490,7 +490,7 @@ def __call__(self, e, iterator=None): | |||
| if not hasattr(iterator, 'iteratorStartOffsetInHierarchy'): | |||
| raise FilterException('Can only run OffsetHierarchyFilter on a RecursiveIterator') | |||
|
|
|||
| offset = s.elementOffset(e) + iterator.iteratorStartOffsetInHierarchy | |||
| offset = opFrac(s.elementOffset(e) + iterator.iteratorStartOffsetInHierarchy) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MusicXML import: forward tags with voice should trigger the same behavior as note tags with voice.
I see this quite a bit in leadsheets where these are used to position chordsym changes within a single melody note. The result should be a second voice containing only hidden rests, but instead, they land in the measure with the notes, and they overlap.