Fix argument annotation in converter.parse() signature
#1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
Nov 18, 2023
| @@ -1375,16 +1376,13 @@ def parse(value: bundles.MetadataEntry | bytes | str | pathlib.Path, | |||
| valueStr = '' | |||
|
|
|||
| if (common.isListLike(value) | |||
| and isinstance(value, collections.abc.Sequence) | |||
There was a problem hiding this comment.
Redundant now that isListLike no longer permits sets
| and len(value) == 2 | ||
| and isinstance(value[1], int) |
There was a problem hiding this comment.
Was preventing the more informative error message below, allowing later elif blocks to match and crash.
Merged
mscuthbert
reviewed
Jan 2, 2024
Comment on lines
+2079
to
+2080
| with self.assertRaises(ConverterException): | ||
| parse((fp, 8)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error reported in #1664 (comment).
Adds missing coverage.