TSV converter bug fix: don't add 'd' prefix to 2-digit added tones like [add13]
#1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimFelixBeyer
added a commit
to TimFelixBeyer/music21
that referenced
this pull request
Sep 2, 2023
commit f457a2b Merge: fdb126c 8b76a3f Author: Michael Scott Asato Cuthbert <michael.asato.cuthbert@gmail.com> Date: Wed Aug 30 22:54:36 2023 -1000 Merge pull request cuthbertLab#1634 from malcolmsailor/add-2-digit-figures TSV converter bug fix: don't add 'd' prefix to 2-digit added tones like `[add13]` commit fdb126c Author: malcolmsailor <malcolm.sailor@gmail.com> Date: Sun Aug 27 10:42:42 2023 -0600 Roman Numerals: Don't substitute `d` for `0` in `add10` (cuthbertLab#1635) commit 8b76a3f Author: Malcolm Sailor <malcolm.sailor@gmail.com> Date: Sat Aug 19 10:20:48 2023 -0400 remove trailing ws commit 9b5e387 Author: Malcolm Sailor <malcolm.sailor@gmail.com> Date: Sat Aug 19 09:50:07 2023 -0400 update commit d3af7bf Author: Malcolm Sailor <malcolm.sailor@gmail.com> Date: Sat Aug 19 08:04:09 2023 -0400 wip commit 3babd94 Author: Malcolm Sailor <malcolm.sailor@gmail.com> Date: Mon Jul 17 14:10:56 2023 -0600 don't match 'add13' when performing dominant 'd' substitution commit 8baa273 Merge: 2a28ab1 9f35bbb Author: Michael Scott Asato Cuthbert <michael.asato.cuthbert@gmail.com> Date: Thu Jul 13 14:07:36 2023 -1000 Merge pull request cuthbertLab#1629 from TimFelixBeyer/patch-5 commit 9f35bbb Author: Tim Beyer <35711942+TimFelixBeyer@users.noreply.github.com> Date: Thu Jul 13 23:56:39 2023 +0200 fix flake commit 4c5ee5f Author: Tim Beyer <35711942+TimFelixBeyer@users.noreply.github.com> Date: Tue Jul 11 23:46:22 2023 +0200 Remove use of hasElement commit 8141355 Author: TimFelix <35711942+TimFelixBeyer@users.noreply.github.com> Date: Sat Jul 8 20:28:08 2023 +0200 Remove uses of `hasElement` commit d43ec76 Author: Tim Beyer <35711942+TimFelixBeyer@users.noreply.github.com> Date: Sat Jul 8 20:16:18 2023 +0200 Speed up __contains__ by 2x and deprecate `hasElement`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex to add
dto Mm7 chords on degrees other than 5 was giving false positives for cases like[add13], where it would match the1, resulting in[addd13]. This PR fixes that bug.I added 2 test cases to
tsvEg_v2major.tsvand discovered that there was another bug where thedsyntax (e.g., forIVd7) was not being removed when converting from Music21 to DCML tsv, although it is not used in the latter standard. So I also added a fix for that.