Don't set status byte on Meta Message (Fix #1574) #1575
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1574
When loading a MIDI file, messages can set a (running) status byte. However, meta messages don't set the status byte.
This leads to problem on several MIDI files, for example 8584aaa73eb54bae39708da8be5e6282.mid from the lakh dataset.
It could be argued that the
!= 0xff
check is too conservative as running status is only applicable for messages in the range0x8n - 0xEn
, the proposal is this way to be aligned with other python midi libraries:https://github.com/mido/mido/blob/bff6bf2a8711e33782de5661ed5ccdffb0bb1688/mido/midifiles/midifiles.py#L204-L206