-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import and export of figured bass elements from MEI and musicxml file formats #1539
Conversation
add Aloha Oe -- whose incorrect interpretation caused this
fixed import and moved figuredBassIndication to harmony
…ht have to be added in the future
Mei import fb support
Add utility for removing duplicated objects (e.g. keys, clefs) (cuthbertLab#1454)
…was erroneously set to 0
Musicxml fb import
…t/Trill was not created with accid, and _never_ for HalfStep/WholeStep Mordent/Trill variations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comment/worry about mei/base.py: I think you started from an older version; you are missing a bunch of stuff that happened in the last year or so (for example the metadata changes I made in v8, and all the typing changes Myke made as well).
This is interesting. I synced with the main repo some weeks ago and thought I used the mei/base.py that is in the current master branch. I will have a look at it. UPDATE: I updated mei/base.py to the newer version. The newer parts didn't affect my changes. |
Pre 9.0 -- Changes
Clean up the User's Guide so that docs in progress are separate from released docs.
Move incomplete docs to testsAndInProgress
…ht have to be added in the future
…was erroneously set to 0
Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Hi. This PR currently changes 200+ files and has hundreds of commits. This won't be possible to review. Can you close and open a new one just with the changes from the "master" branch? |
As I came back to this topic today, I thought similar. Rebasing my fork to the new version triggered the checks here I think. I'll close this PR and open a new one when I have the stuff ready. |
(1) Added the possibility to import musicxml and MEI representations of figured bass notations.
(2) Proposes also a class to represent Figured Bass in a music21 stream. The class is called FiguredBassIndication and inherits from the harmony object using the already existing objects from the figuredbass module.
Any comments are highly appreciated. A discussion in the google list is here available: https://groups.google.com/g/music21list/c/-Z_UQfZ9SPk/m/gyE9DciUCgAJ