WIP: Instantiation w/ **keywords tests #1463
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Came up with an idea that should make deepcopying music21 objects MUCH faster, but also set up FrozenDuration to have __deepcopy__ return self. as in copy._deepcopy_atomic
mscuthbert
added a commit
that referenced
this pull request
Oct 14, 2022
Merging this rather than #1463 but some good improvements there that need to be integrated.
|
Closing in favor of #1464 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEMPORARILY Restoring an old requirement for Music21Objects that require them to be instantiable without ().
I think that this is the wrong approach now that I'm working on it, and will probably close in favor of a
__new__based deepcopy rather than__init__based.