Fix (and test) writing of multi-measure RepeatBrackets to MusicXML. #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pylint fail is not me... |
|
Ready to go... |
|
OK, fine, I forgot to add another test to ALL. Added two, since I forgot one a while back. |
|
Ready to go |
|
Thanks -- apparently a new feature of pylint 2.15.0 which was released 3 days ago. I have branch protection on right now, so let me merge #1403 and then this should automatically work. |
|
Sorry! Forgot to merge after I fixed the bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the first and middle measures all had a 'stop' ending on the right barline.