Emphasize Pitches in Interval classes #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents problems with client disappearing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store only Pitch elements in Interval(), not Notes, and depend on Pitch._client to get the notes back.
Simplifies the Interval object and speeds it up if we're not constantly looking at Pitch or Note at any moment. Improves typing.
More importantly, the client for the Pitch will not change when transposed inPlace and therefore chordAttached on the note will also not change. This was important with cached methods like isConsonant when one of the individual pitches in the Chord was being transposed. Now client is informed.