Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit Keywords on all music21 objects #1377

Merged
merged 25 commits into from
Aug 17, 2022
Merged

Explicit Keywords on all music21 objects #1377

merged 25 commits into from
Aug 17, 2022

Conversation

mscuthbert
Copy link
Member

Fixes #839

Each push will include one or more modules.

Starting with Base.

Fixes #839

Each push will include one or more modules.

Starting with Base.
@coveralls
Copy link

coveralls commented Aug 14, 2022

Coverage Status

Coverage increased (+0.02%) to 93.038% when pulling 4cb3228 on explicit-keywords into 1a0ec50 on master.

@mscuthbert mscuthbert marked this pull request as ready for review August 17, 2022 00:02
@mscuthbert mscuthbert merged commit 0618c1a into master Aug 17, 2022
@mscuthbert
Copy link
Member Author

Misc fixes:

  • Metadata date formats derive from DatePrimitive not DateSingle (attn: @gregchapman-dev)
  • remove unused note.linkage
  • kwargs -> keywords throughout
  • fix metadata tests pinned to 8.0.0a9

Modules/Classes affected include:

  • base
  • Tuplet
  • note
  • Stream
  • chordBase
  • discrete analysis
  • Variant (now takes only one arg)
  • midi realtime, etc.
  • Chorales, Date primitives, RepeatBracket
  • layout

@mscuthbert mscuthbert deleted the explicit-keywords branch August 18, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keywords need to be part of the function signature
3 participants