Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add makeNotation argument to test utility #1376

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Add makeNotation argument to test utility #1376

merged 1 commit into from
Aug 15, 2022

Conversation

jacobtylerwalls
Copy link
Member

I finally could ignore this no longer! Add a makeNotation=True default to test helper getET to encourage most unit tests to go through the usual codepath. Make explicit where existing tests actually depended on notation not being made.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 93.028% when pulling ba8247b on getET into 1a0ec50 on master.

@mscuthbert
Copy link
Member

thank you. this is what I should've done from the beginning.

@mscuthbert mscuthbert merged commit d68cdd6 into master Aug 15, 2022
@mscuthbert mscuthbert deleted the getET branch August 15, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants