Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate gcd in favor of C math #1343

Merged
merged 6 commits into from
Jul 14, 2022
Merged

deprecate gcd in favor of C math #1343

merged 6 commits into from
Jul 14, 2022

Conversation

mscuthbert
Copy link
Member

@mscuthbert mscuthbert commented Jul 14, 2022 •
edited
Loading

math.gcd and math.lcm were added and use C-speed.

math.gcd is Py3.8; ok. lcm is Py3.9, not ok.

@mscuthbert mscuthbert changed the title deprecate gcd and lcm in favor of C math deprecate gcd in favor of C math Jul 14, 2022
@mscuthbert mscuthbert merged commit a248964 into master Jul 14, 2022
@mscuthbert mscuthbert deleted the lcm_gcd branch July 14, 2022 14:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 93.084% when pulling 618c612 on lcm_gcd into 7886887 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscuthbert @coveralls