Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shiftElements docs #1326

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Fix shiftElements docs #1326

merged 1 commit into from
Aug 3, 2022

Conversation

jacobtylerwalls
Copy link
Member

startOffset and endOffset in this method work like excluding filters -- so this should read that elements outside the bounds are not shifted.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.054% when pulling ea7c78a on fix-shift-doc into c46bde4 on master.

@mscuthbert mscuthbert merged commit b036467 into master Aug 3, 2022
@mscuthbert mscuthbert deleted the fix-shift-doc branch August 3, 2022 07:34
@mscuthbert
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobtylerwalls @coveralls @mscuthbert