Export Unpitched to MIDI #1315
Merged
Export Unpitched to MIDI #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
commented
May 21, 2022
| @@ -1776,6 +1776,7 @@ class Unpitched(NotRest): | |||
|
|
|||
| def __init__(self, displayName=None, **keywords): | |||
| super().__init__(**keywords) | |||
| self._chordAttached: t.Optional['music21.percussion.PercussionChord'] = None | |||
There was a problem hiding this comment.
This was already being set in ChordBase._add_core_or_init(), but without being initialized anywhere.
jacobtylerwalls
changed the title
|
Super wonderful! Thank you! Is there a test for if the instrument is stored directly on the unpitched element? Can be added later. |
jacobtylerwalls
commented
May 23, 2022
Comment on lines
+4090
to
+4100
| # Change the stored instrument: affects that note only | ||
| m.notes.first().storedInstrument = instrument.Agogo() | ||
|
|
||
| trks = streamHierarchyToMidiTracks(m) | ||
| mixed_trk = trks[1] | ||
|
|
||
| self.assertTrue({ev.channel for ev in mixed_trk.events}, {10}) | ||
| note_ons = [ | ||
| ev for ev in mixed_trk.events if ev.type is midiModule.ChannelVoiceMessages.NOTE_ON] | ||
| self.assertEqual(len(note_ons), 3) | ||
| self.assertEqual([ev.pitch for ev in note_ons], [67, 60, 60]) |
There was a problem hiding this comment.
Yep, if I'm following, then that's tested here: put Agogo on the first unpitched note in the stream and get midi note 67 on that one only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238