Avoid writing empty <movement-title /> and <creator /> tags when title and author have no defaults
#1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid writing empty tags for movement-title and creator
|
I'm going to merge this right after releasing 7.3 -- it'll be a v8 feature. |
|
Not sure about the merge looking more -- is there a way to make these optional without removing a m21 style that has been around since v0.1? It is in one sense a small change, but also a huge one that removes the branding of the system which has persisted over 16 years. |
|
No worries, let's leave the branding in. I'll update this to just accomplish the functional change of not writing empty tags when someone opts-in to empty defaults. |
jacobtylerwalls
changed the title
<movement-title /> and <creator />` tags when title and author have no defaults
jacobtylerwalls
changed the title
<movement-title /> and <creator />` tags when title and author have no defaults<movement-title /> and <creator /> tags when title and author have no defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove title and author defaults, andavoid writing empty tags for<movement-title />and<creator />.