Compatibility with DotNetty

cuteant · May 25, 2021 · a4c3a41 · a4c3a41
1 parent f20a710
commit a4c3a41
Show file tree

Hide file tree

Showing 8 changed files with 63 additions and 1 deletion.
diff --git a/src/DotNetty.Codecs.Http2/AbstractHttp2StreamChannel.cs b/src/DotNetty.Codecs.Http2/AbstractHttp2StreamChannel.cs
@@ -128,12 +128,18 @@ internal void StreamClosed()
 
         public IChannelConfiguration Configuration => _config;
 
+        [Obsolete("Please use IsOpen instead.")]
+        public bool Open => IsOpen;
+
         public bool IsOpen
         {
             [MethodImpl(InlineMethod.AggressiveOptimization)]
             get => !_closePromise.IsCompleted;
         }
 
+        [Obsolete("Please use IsActive instead.")]
+        public bool Active => IsActive;
+
         public bool IsActive => IsOpen;
 
         public bool IsWritable => 0u >= (uint)Volatile.Read(ref v_unwritable);
@@ -144,6 +150,9 @@ public bool IsOpen
 
         public IChannel Parent => ParentContext.Channel;
 
+        [Obsolete("Please use IsRegistered instead.")]
+        public bool Registered => IsRegistered;
+
         public bool IsRegistered => InternalRegistered;
 
         public EndPoint LocalAddress => Parent.LocalAddress;

diff --git a/src/DotNetty.Transport/Channels/AbstractChannel.cs b/src/DotNetty.Transport/Channels/AbstractChannel.cs
@@ -150,8 +150,14 @@ public IEventLoop EventLoop
             }
         }
 
+        [Obsolete("Please use IsOpen instead.")]
+        public bool Open => IsOpen;
+
         public abstract bool IsOpen { get; }
 
+        [Obsolete("Please use IsActive instead.")]
+        public bool Active => IsActive;
+
         public abstract bool IsActive { get; }
 
         public abstract ChannelMetadata Metadata { get; }
@@ -215,6 +221,9 @@ protected EndPoint CacheRemoteAddress()
             }
         }
 
+        [Obsolete("Please use IsRegistered instead.")]
+        public bool Registered => IsRegistered;
+
         public bool IsRegistered => SharedConstants.False < (uint)Volatile.Read(ref v_registered);
 
         /// <summary>

diff --git a/src/DotNetty.Transport/Channels/AbstractChannelHandlerContext.cs b/src/DotNetty.Transport/Channels/AbstractChannelHandlerContext.cs
@@ -116,7 +116,7 @@ private bool InvokeHandler
             }
         }
 
-        [Obsolete("=>IsRemoved")]
+        [Obsolete("Please use IsRemoved instead.")]
         public bool Removed => IsRemoved;
 
         public bool IsRemoved => 0u >= (uint)(Volatile.Read(ref v_handlerState) - HandlerState.RemoveComplete);

diff --git a/src/DotNetty.Transport/Channels/CombinedChannelDuplexHandler.Context.cs b/src/DotNetty.Transport/Channels/CombinedChannelDuplexHandler.Context.cs
@@ -61,6 +61,9 @@ public DelegatingChannelHandlerContext(IChannelHandlerContext ctx, IChannelHandl
 
             public IChannelHandler Handler => _ctx.Handler;
 
+            [Obsolete("Please use IsRemoved instead.")]
+            public bool Removed => IsRemoved;
+
             public bool IsRemoved => _removed || _ctx.IsRemoved;
 
             public IChannelHandlerContext FireChannelRegistered()

diff --git a/src/DotNetty.Transport/Channels/DefaultChannelConfiguration.cs b/src/DotNetty.Transport/Channels/DefaultChannelConfiguration.cs
@@ -241,6 +241,13 @@ public virtual IMessageSizeEstimator MessageSizeEstimator
             }
         }
 
+        [Obsolete("Please use IsAutoRead instead.")]
+        public bool AutoRead
+        {
+            get => IsAutoRead;
+            set => IsAutoRead = value;
+        }
+
         public bool IsAutoRead
         {
             get { return SharedConstants.False < (uint)Volatile.Read(ref _autoRead); }
@@ -264,6 +271,13 @@ protected virtual void AutoReadCleared()
         {
         }
 
+        [Obsolete("Please use IsAutoClose instead.")]
+        public bool AutoClose
+        {
+            get => IsAutoClose;
+            set => IsAutoClose = value;
+        }
+
         public bool IsAutoClose
         {
             get { return SharedConstants.False < (uint)Volatile.Read(ref _autoClose); }

diff --git a/src/DotNetty.Transport/Channels/IChannel.cs b/src/DotNetty.Transport/Channels/IChannel.cs
@@ -107,6 +107,15 @@ public interface IChannel : IAttributeMap, IComparable<IChannel>, IEquatable<ICh
         /// </summary>
         IChannel Parent { get; }
 
+        [Obsolete("Please use IsOpen instead.")]
+        bool Open { get; }
+
+        [Obsolete("Please use IsActive instead.")]
+        bool Active { get; }
+
+        [Obsolete("Please use IsRegistered instead.")]
+        bool Registered { get; }
+
         /// <summary>
         /// Returns <c>true</c> if the <see cref="IChannel"/> is open and may get active later.
         /// </summary>

diff --git a/src/DotNetty.Transport/Channels/IChannelConfiguration.cs b/src/DotNetty.Transport/Channels/IChannelConfiguration.cs
@@ -67,10 +67,20 @@ public interface IChannelConfiguration
         /// <summary>Gets or sets the <see cref="IRecvByteBufAllocator"/> which is used for the channel to allocate receive buffers.</summary>
         IRecvByteBufAllocator RecvByteBufAllocator { get; set; }
 
+        /// <summary>Gets or sets if <see cref="IChannelHandlerContext.Read()"/> will be invoked automatically so that a user application doesn't
+        /// need to call it at all. The default value is <c>true</c>.</summary>
+        [Obsolete("Please use IsAutoRead instead.")]
+        bool AutoRead { get; set; }
+
         /// <summary>Gets or sets if <see cref="IChannelHandlerContext.Read()"/> will be invoked automatically so that a user application doesn't
         /// need to call it at all. The default value is <c>true</c>.</summary>
         bool IsAutoRead { get; set; }
 
+        /// <summary>Gets or sets whether the <see cref="IChannel"/> should be closed automatically and immediately on write failure.
+        /// The default is <c>true</c>.</summary>
+        [Obsolete("Please use IsAutoClose instead.")]
+        bool AutoClose { get; set; }
+
         /// <summary>Gets or sets whether the <see cref="IChannel"/> should be closed automatically and immediately on write failure.
         /// The default is <c>true</c>.</summary>
         bool IsAutoClose { get; set; }

diff --git a/src/DotNetty.Transport/Channels/IChannelHandlerContext.cs b/src/DotNetty.Transport/Channels/IChannelHandlerContext.cs
@@ -168,6 +168,14 @@ public interface IChannelHandlerContext : IAttributeMap
         /// </summary>
         IChannelHandler Handler { get; }
 
+        /// <summary>
+        /// Return <c>true</c> if the <see cref="IChannelHandler"/> which belongs to this context was removed
+        /// from the <see cref="IChannelPipeline"/>. Note that this method is only meant to be called from with in the
+        /// <see cref="IEventLoop"/>.
+        /// </summary>
+        [Obsolete("Please use IsRemoved instead.")]
+        bool Removed { get; }
+
         /// <summary>
         /// Return <c>true</c> if the <see cref="IChannelHandler"/> which belongs to this context was removed
         /// from the <see cref="IChannelPipeline"/>. Note that this method is only meant to be called from with in the