Merge pull request #5 from customeros/adjust-validation-for-add-contacts

change linkedin validation for add contacts + add linkedin url
customeros · Feb 18, 2025 · 0709c6a · 0709c6a
2 parents 3b358ec + c70c706
commit 0709c6a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/src/domain/usecases/contact-details/add-linkedin.usecase.ts b/src/domain/usecases/contact-details/add-linkedin.usecase.ts
@@ -75,7 +75,7 @@ export class LinkedIn {
     } else {
       this.emptyLinkedInUrl = false;
 
-      const linkedInUrlPattern = /^(https?:\/\/)?(www\.)?linkedin\.com\/.*$/;
+      const linkedInUrlPattern = /linkedin\.com\/in\/[^/]+\/?$/;
 
       if (!linkedInUrlPattern.test(url)) {
         this.invalidLinkedInUrl = true;

diff --git a/src/domain/usecases/contact-details/create-contact.usecase.ts b/src/domain/usecases/contact-details/create-contact.usecase.ts
@@ -34,7 +34,7 @@ export class CreateContactUsecase {
   @observable static accessor isBrowserExtensionEnabled: boolean = true;
 
   private readonly PATTERNS = {
-    linkedin: /linkedin\.com\/in\/[^/]+$/,
+    linkedin: /linkedin\.com\/in\/[^/]+\/?$/,
     email: /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/,
   };
 
@@ -168,6 +168,8 @@ export class CreateContactUsecase {
     this.inputValue = '';
     this.isLoading = false;
     this.type = 'linkedin';
+    this.root.ui.commandMenu.toggle('AddSingleContact');
+    this.root.ui.commandMenu.clearContext();
   }
 
   @action

diff --git a/src/routes/src/components/CommandMenu/commands/contacts/AddSingleContact.tsx b/src/routes/src/components/CommandMenu/commands/contacts/AddSingleContact.tsx
@@ -172,7 +172,7 @@ export const AddSingleContact = observer(() => {
             : usecase.currentError.message
             ? usecase.currentError.message
             : usecase.currentError.isInvalid
-            ? `Invalid ${usecase.type} format`
+            ? `This ${usecase.type} seems to be incorrect`
             : ''}
         </p>
 

diff --git a/src/utils/linkedinValidation.ts b/src/utils/linkedinValidation.ts
@@ -1,6 +1,5 @@
 export function validLinkedInProfileUrl(url: string): boolean {
-  const re =
-    /(https?:\/\/(www\.)|(www\.))?linkedin\.com\/(mwlite\/|m\/)?in\/[a-zA-Z0-9-]+\/?$/;
+  const re = /linkedin\.com\/in\/[^/]+\/?$/;
 
   return re.test(url);
 }