Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update CustomerIOFirebaseMessagingService to open #174

Merged
merged 1 commit into from
Feb 22, 2023
Merged

fix: update CustomerIOFirebaseMessagingService to open #174

merged 1 commit into from
Feb 22, 2023

Conversation

mrehan27
Copy link
Contributor

Helps: https://github.com/customerio/issues/issues/9477

Changes

  • Updated CustomerIOFirebaseMessagingService access to open so we can inherit it in wrapper SDKs

@mrehan27 mrehan27 requested a review from a team February 22, 2023 14:30
@github-actions
Copy link

github-actions bot commented Feb 22, 2023 •
edited
Loading

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@codecov
Copy link

codecov bot commented Feb 22, 2023 •
edited
Loading

Codecov Report

Merging #174 (cd6d67d) into beta (0abdc85) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               beta     #174      +/-   ##
============================================
+ Coverage     62.02%   62.12%   +0.09%     
  Complexity      210      210              
============================================
  Files            91       91              
  Lines          2041     2041              
  Branches        258      258              
============================================
+ Hits           1266     1268       +2     
+ Misses          678      676       -2     
  Partials         97       97
Impacted Files Coverage Δ
...essagingpush/CustomerIOFirebaseMessagingService.kt 0.00% <0.00%> (ø)
...src/main/java/io/customer/sdk/queue/QueueRunner.kt 26.82% <0.00%> (+2.43%) ⬆️
...ain/java/io/customer/sdk/api/TrackingHttpClient.kt 38.09% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Build available to test
Version: fix-notification-service-visibility-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@mrehan27 mrehan27 changed the title fix: updated CustomerIOFirebaseMessagingService to open fix: update CustomerIOFirebaseMessagingService to open Feb 22, 2023
Shahroz16
Shahroz16 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we ned to make methods open too? are do you plan on making them open when the need arise?

@mrehan27
Copy link
Contributor Author

@Shahroz16 Not really I think, as the only two methods outside companion object are already overriden.

@Shahroz16 Shahroz16 merged commit edce7f5 into beta Feb 22, 2023
@Shahroz16 Shahroz16 deleted the fix/notification-service-visibility branch February 22, 2023 17:53
github-actions bot pushed a commit that referenced this pull request Feb 22, 2023
@semantic-release-bot
chore: prepare for 3.3.0-beta.5
c18ad4d 
## [3.3.0-beta.5](3.3.0-beta.4...3.3.0-beta.5) (2023-02-22)

### Bug Fixes

* update CustomerIOFirebaseMessagingService to open ([#174](#174)) ([edce7f5](edce7f5))
@github-actions
Copy link

🎉 This PR is included in version 3.3.0-beta.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Feb 22, 2023
@semantic-release-bot
chore: prepare for 3.3.0
677d981 
## [3.3.0](3.2.0...3.3.0) (2023-02-22)

### Features

* add setting a in-app event listener ([#147](#147)) ([5fd9559](5fd9559))
* in-app feature no longer requires orgId ([#163](#163)) ([fc2a08e](fc2a08e))

### Bug Fixes

* image not shown when image url in notification payload ([#172](#172)) ([0abdc85](0abdc85))
* moved shared wrapper code ([#158](#158)) ([51af98f](51af98f))
* remove currentRoute parameter in in-app event listener ([#159](#159)) ([688e4a5](688e4a5))
* rename in app listener keys ([#164](#164)) ([f540eaf](f540eaf))
* set gist dependency to use latest 3.X.Y version ([#170](#170)) ([a019c36](a019c36))
* set gist user token incase identifier exists ([#162](#162)) ([44cc4d1](44cc4d1))
* update CustomerIOFirebaseMessagingService to open ([#174](#174)) ([edce7f5](edce7f5))
* upgrade dependencies ([#146](#146)) ([6da8b8d](6da8b8d))
* use maven style dependency range syntax ([#171](#171)) ([ba83214](ba83214))
@github-actions
Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shahroz16 Shahroz16 Shahroz16 approved these changes

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrehan27 @Shahroz16