Remove async keyword, avoid iooxa undefined issue #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Awesome work @rowanc1 ! Sorry I couldn't come back to your project before, but now I'm starting again with the new
iooxa
package you've made :-)I love the changes so far! I am now trying to do more complex stuff (I also learnt a bit of modern javascript since then :-) ), so here are a few suggestions to improve the doc IMHO:
Remove the async keyword in the intro to avoid this issue when trying to access
iooxa
from a custom javascript function. It may be obvious for more experienced JS developers but for me it wasn't :-/ So I'd suggest it's better show an intro example that doesn't risk the user running into this issue. This is what this PR does.Add the examples you wrote here in the doc, in a new section "custom javascript functions"? Right now the doc only includes a section for "Runtime" which is great to build new components, but it doesn't explain how to access programmatically already existing components through
iooxa
.How to call custom javascript functions, as previously discussed here (although it seems these examples do not work anymore or at least not on all input types, as the
:change
attribute cannot call JS functions onr-select
for example, didn't yet try others).