Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing features to RewardsHandler #8

Merged
merged 20 commits into from
Sep 19, 2024
Merged

feat: add missing features to RewardsHandler #8

merged 20 commits into from
Sep 19, 2024

Conversation

AlbertoCentonze
Copy link
Collaborator

@AlbertoCentonze AlbertoCentonze commented Sep 18, 2024 •
edited
Loading

  • correctly implement eip165
  • prefer interface as type over address
  • lens is now used as a module and not an external contract
  • expose circulating supply as an external endpoint
  • a bunch of docs (yes, I didn't use chatgpt)

@AlbertoCentonze
feat: add missing features to RewardsHandler
2985e28 
* correctly implement eip165
* prefer interface as type over address
* lens is now used as a module and not an external contract
* expose circulating supply as an external endpoint
@AlbertoCentonze
fix: remove unlock time update at distribution
fcc4f43
@AlbertoCentonze
docs: natspec for RewardsHandler
9d9b4ef 
* `RATE_ADMIN` -> `RATE_MANAGER` to avoid confusions with role admins from the `access_control.vy` module.
* document functions
* use `set` instead of `adjust` for setters
@AlbertoCentonze
style: reorder functions + headers
8ace734
@AlbertoCentonze
feat: better role management
95accd2
@AlbertoCentonze
docs: top contract description
91b55ce
@AlbertoCentonze
docs: access control rationale
6958f5b
@AlbertoCentonze
feat: add recovery function for erc20
25e25fd
@AlbertoCentonze
fix: remove dangerous external function
f6f4826
@AlbertoCentonze
docs: note on MEV
2600e63
@AlbertoCentonze
chore: add TODOs
f0256c8
@AlbertoCentonze AlbertoCentonze marked this pull request as ready for review September 18, 2024 16:40
heswithme
heswithme approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@heswithme heswithme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multiple points discussed & fixed in-person, however tests shall be fixed. Can merge with failing tests, or commit conftest here.

@AlbertoCentonze AlbertoCentonze merged commit 0db7e2c into main Sep 19, 2024
1 of 2 checks passed
@AlbertoCentonze AlbertoCentonze deleted the finalize-rewards-handler branch September 19, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heswithme heswithme heswithme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlbertoCentonze @heswithme