Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from ape to boa #14

Merged
merged 19 commits into from
Dec 12, 2023
Merged

Migrate from ape to boa #14

merged 19 commits into from
Dec 12, 2023

Conversation

DanielSchiavini
Copy link
Collaborator

@DanielSchiavini DanielSchiavini commented Nov 22, 2023 •
edited
Loading

  • Get rid of ape and brownie, and use only boa instead.
  • Simplify the configuration and set up, variables expected in the environment
  • Added documentation for all scripts
  • A lot of tests needed updates since they are using production data and that includes many more edge cases.

@DanielSchiavini DanielSchiavini self-assigned this Nov 22, 2023
DanielSchiavini
DanielSchiavini commented Dec 11, 2023
View reviewed changes
Copy link
Collaborator Author

@DanielSchiavini DanielSchiavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are finally green, a few todo's remaining

tests/mainnet/metaregistry/api/test_get_admin_balances.py Show resolved Hide resolved
tests/utils.py Show resolved Hide resolved
@DanielSchiavini DanielSchiavini changed the title WIP: Migrate from ape to boa Migrate from ape to boa Dec 12, 2023
@DanielSchiavini DanielSchiavini marked this pull request as ready for review December 12, 2023 08:29
bout3fiddy
bout3fiddy approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@bout3fiddy bout3fiddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this comprehensive migration to boa.

This allows me to build NG registry handlers and expand to other chains :). If there are issues I discover, I'll add them and we can tackle them.

For now, it looks good!

@bout3fiddy bout3fiddy merged commit 86a1314 into main Dec 12, 2023
2 checks passed
@bout3fiddy bout3fiddy deleted the boa branch December 12, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bout3fiddy bout3fiddy bout3fiddy approved these changes

Assignees

@DanielSchiavini DanielSchiavini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielSchiavini @bout3fiddy