Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated leading and trailing delimiters for before and after positions #340

Merged
merged 2 commits into from
Nov 29, 2021

Conversation

AndreasArvidsson
Copy link
Member

Delimiter was not aggressive enough for positions before/after. Many times chuck before token would fail.
Updated delimiter code and added additional tests.

@pokey
Copy link
Member

pokey commented Nov 29, 2021

I thought we decided to replace these with their own modifiers in #309

Is this code useful for anything other than "chuck after"? Conversely, can we easily use this code for "chuck trailing"?

Also hesitant to add a bunch of unit tests for something we're shortly removing

@AndreasArvidsson
Copy link
Member Author

We will but I need this one right now because it's bugging the hell out of me. Much of the same logic can be reused of course and I think I change like three lines. You always likes when I had lot of tests :D

@pokey
Copy link
Member

pokey commented Nov 29, 2021

We will but I need this one right now because it's bugging the hell out of me. Much of the same logic can be reused of course and I think I change like three lines. You always likes when I had lot of tests :D

yeah i'm not going to spend too much time arguing against tests 😄. I've added a note to update these tests once #309 is implemented

@AndreasArvidsson AndreasArvidsson merged commit 5cdb954 into main Nov 29, 2021
@AndreasArvidsson AndreasArvidsson deleted the position_delimiters branch November 29, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants