Skip to content

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Nov 17, 2022

Checklist

@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review November 20, 2022 14:17
@AndreasArvidsson
Copy link
Member Author

@pokey ready

This was referenced Dec 4, 2022
@pokey
Copy link
Member

pokey commented Dec 4, 2022

Ok looks good to me; created #1160 and #1161 to track some things we should discuss / rework, and left a couple of comments

I also pushed some changes; have a look

@pokey pokey self-assigned this Dec 6, 2022
@pokey pokey force-pushed the free_actions_from_vscode branch from c776b83 to e11f455 Compare December 7, 2022 15:04
@pokey pokey force-pushed the free_actions_from_vscode branch from 45075a9 to 1d93c98 Compare December 7, 2022 15:18
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok @AndreasArvidsson have a look; I think it's good to go

@pokey pokey assigned AndreasArvidsson and unassigned pokey Dec 7, 2022
@pokey pokey merged commit f041217 into main Dec 8, 2022
@pokey pokey deleted the free_actions_from_vscode branch December 8, 2022 13:12
@pokey pokey mentioned this pull request Jan 9, 2023
3 tasks
AndreasArvidsson added a commit that referenced this pull request Jan 10, 2023
- This one most likely broke in #1143, but I'm not certain

## Checklist

- [x] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

Co-authored-by: Andreas Arvidsson <andreas.arvidsson87@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants