fix: forward configuration context to executor #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agoldis Hey, anyway to merge this so I don't have to use a forked NPM version? |
agoldis
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
@webberwang Thanks a lot for your help and sorry for the delayed response!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any
-cflags don't get forwarded to the e2e callFor example,
nx run app-e2e:currents:ciornx run app-e2e:currents -c ci, thecidoesn't get forwarded to when currents call thee2escript.If your
e2ehas configurations forci,devetc, these settings won't be properly applied.