Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tool_hugehelp.c into IBMi build. #16215

Closed

Conversation

andrewkirillov-ibm
Copy link
Contributor

This fixed issue #16214.

As tool_hugehelp.c is no longer included into Makefile.inc, I did add it explicitly to list of source files built on IBMi.

vszakats
vszakats previously approved these changes Feb 6, 2025
@vszakats vszakats dismissed their stale review February 6, 2025 13:13

shellcheck issue needs fixing.

@vszakats
Copy link
Member

vszakats commented Feb 6, 2025

shellcheck reports:

In packages/OS400/make-src.sh line 65:
for SRC in ${CURLX_CFILES}
           ^-------------^ SC2153 (info): Possible misspelling: CURLX_CFILES may not be assigned. Did you mean CURL_CFILES?

perhaps try this to silence?

--- a/packages/OS400/make-src.sh
+++ b/packages/OS400/make-src.sh
@@ -55,6 +55,7 @@ MODULES=
 # shellcheck disable=SC2034
 INCLUDES="'${TOPDIR}/lib'"
 
+# shellcheck disable=SC2153
 for SRC in ${CURLX_CFILES}
 do      MODULE=$(db2_name "${SRC}")
         MODULE=$(db2_name "X${MODULE}")

@andrewkirillov-ibm
Copy link
Contributor Author

Done, # shellcheck disable=SC2153

packages/OS400/make-src.sh Outdated Show resolved Hide resolved
@vszakats vszakats closed this in 449d9f7 Feb 6, 2025
@vszakats
Copy link
Member

vszakats commented Feb 6, 2025

Thanks, merged now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants