[FIX] Fix flaky embargo tests #2441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**ISSUE** The embargo specs fail intermittently when run in the full suite. **DIAGNOSIS** Depending on the randomized test order, the admin tests may run before the regular user tests. In some test orders, the admin user may remain logged in while the tests for regular users are run resulting in admin-only data being rendered in the views. **FIX** Explicitly log out any user from a previous test when testing regular or unauthenticated user views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
The embargo specs fail intermittently when run in the full suite.
DIAGNOSIS
Depending on the randomized test order, the admin tests may run before the regular user tests. In some test orders, the admin user may remain logged in while the tests for regular users are run resulting in admin-only data being rendered in the views.
FIX
Explicitly log out any user from a previous test when testing regular or unauthenticated user views.