Only run ActiveFedora cleaner once per example #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In trying to mimic transactional database rollback behavior, the `clean` tag was set up to wipe out Fedora data both before and after examples were run. Cleaning Fedora is different than rolling back transactions that occured during the test (and takes more time). Our long-term goal is to run clean only where absolutely necessary. This change starts that process by eliminating unnecessary cleaning after examples.
mlooney
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to mimic transactional database rollback behavior, the
cleantag was set up to wipe out Fedora data both before andafter examples were run. Cleaning Fedora is different than rolling
back transactions that occured during the test (and takes more time).
Our long-term goal is to run clean only where absolutely necessary.
This change starts that process by eliminating unnecessary cleaning
after examples.