Fix flaky GraduationJob tests #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests in the GraduationJob test group are periodically failing with the same error: ``` ActiveRecord::RecordNotFound: Couldn't find Hyrax::PermissionTemplate ./lib/workflow_setup.rb:156:in `block in everyone_can_deposit_everywhere' ./lib/workflow_setup.rb:154:in `everyone_can_deposit_everywhere' ./lib/workflow_setup.rb:44:in `setup' ./spec/jobs/graduation_job_with_embargo_spec.rb:46:in `block (3 levels) in <top (required)>' ``` This failure is occuring in the workflow setup called in the `before` block for the test group. It appears that depending on the randomized order of other tests, the AdminSets and Workflow may be left in a state incompatible with the workflow setup for this test group, causing the setup to silently fail. Explicitly resetting Fedora to a clean state allows the workflow setup to run successfully and leave Workflows in the state expected by the rest of the test group.
mlooney
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests in the GraduationJob test group are periodically failing
with the same error:
See an example at https://app.circleci.com/pipelines/github/curationexperts/laevigata/504/workflows/bd115b16-c926-461a-b739-cb9c864d3763/jobs/536/tests#failed-test-0
This failure is occuring in the workflow setup called in the
beforeblockfor the test group. It appears that depending on the randomized order of other
tests, the AdminSets and Workflow may be left in a state incompatible with
the workflow setup for this test group, causing the setup to silently fail.
Explicitly resetting Fedora to a clean state allows the workflow setup
to run successfully and leave Workflows in the state expected by
the rest of the test group.