Speed up contact page test #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test loaded and executed remote javascript from the libwizard site. While it's useful to know that this code is running successfully and inserting the expected iframe form into the ETD Help page, the test takes a very long time to run and the javascript does not always load from the remote site before the test times out. This change flags that test as a smoke_test that is not run during regular runs of the test suite. It also adds a view test that ensures the default Hyrax contact form is replaced by the local form which embeds the expected libwizard script.
mlooney
approved these changes
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test loaded and executed remote javascript from the
libwizard site. While it's useful to know that this code is running
successfully and inserting the expected iframe form into the ETD Help
page, the test takes a very long time to run and the javascript does
not always load from the remote site before the test times out.
This change flags that test as a smoke_test that is not run during
regular runs of the test suite. It also adds a view test that ensures
the default Hyrax contact form is replaced by the local form which
embeds the expected libwizard script.