fixed class shifting in single byte tags

Signed-off-by: Theis <theismejnertsen@gmail.com>
cunicu · Oct 10, 2024 · cc3d9e4 · cc3d9e4
1 parent 357d477
commit cc3d9e4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/encoding/tlv/ber.go b/encoding/tlv/ber.go
@@ -25,7 +25,7 @@ func NewBERTag(number uint, class Class) Tag {
 	var tag uint
 
 	if number < 0x1F {
-		return Tag(number | (uint(class) >> 6))
+		return Tag(number | (uint(class) << 6))
 	}
 
 	tag = 0x1F | (uint(class) << 6)

diff --git a/encoding/tlv/ber_test.go b/encoding/tlv/ber_test.go
@@ -19,6 +19,7 @@ func TestTagBER(t *testing.T) {
 		class       tlv.Class
 		constructed bool
 	}{
+		{tlv.NewBERTag(0x2, tlv.ClassContext), tlv.ClassContext, false},
 		{tlv.NewBERTag(0x20, tlv.ClassUniversal), tlv.ClassUniversal, false},
 		{tlv.NewBERTag(0x200, tlv.ClassContext), tlv.ClassContext, false},
 		{tlv.NewBERTag(0x20000, tlv.ClassPrivate), tlv.ClassPrivate, false},