-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: warn about flutter snap package #499
Conversation
I see you've pushed some changes. The only one that I'd object to is using the same hyperlink target twice without taking advantage of Markdown's substitution mechanism. But it's not my call to make... |
I see your point. I was trying to match the formatting with that of other pages, but I think your method can also work. I'll restore the link as per your suggestion :) |
This reverts commit c2aec0e.
I'm pretty good with mkdocs and Github Actions. Using ReadTheDocs can allow a way preview docs changes in a PR without building the branch locally (see RTD docs for more detail) I would also limit the other CI triggers to only run the workflow on relavent changes (see gitub docs for more detail). For example, it wouldn't make sense to run unit tests on changes that only affect the docs 😉 . Here, I think the test-app and example-app CI ran because of the addition to gitignore. |
Currently, Any RTD-related PR is also welcome if it actually improves the workflow. |
An admin for cunarist would have to import this repo into a RTD account (using Github credentials to sign in) and enable PR builds in the RTD project's settings. Afterward, it would be as simple as adding a |
resolves #498
Changes
This replaces a footnote (about avoiding the flutter snap package) with an admonition and notes that app stores (at least on debian-based Linux distros) offer flutter SDK as a snap package.