Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

III-6410 Cleanup auth0 Code #328

Merged
merged 10 commits into from
Nov 19, 2024
Merged

III-6410 Cleanup auth0 Code #328

merged 10 commits into from
Nov 19, 2024

Conversation

JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Nov 18, 2024

Changed

  • app/RoutingServiceProvider: pemfile will only be the Keycloak one & getManagementTokenProvider() will always be a Keycloak one.
  • JsonDocumentFetcherProvider: getTokenGenerator() will always return a KeycloakTokenGenerator
  • Authentication/AuthenticateRequest: rename $auth0Down to $oAuthServerDown & $jwtUrl is always set.
  • AuthenticateRequestTest: Use KeycloakMetadataGenerator instead of Auth0MetadataGenerator in tests & update MockResponses with Keycloak metadata.

Removed

  • Auth0TokenGenerator
  • Auth0MetadataGenerator

Related PR


Ticket: https://jira.publiq.be/browse/III-6410

@JonasVHG JonasVHG marked this pull request as ready for review November 18, 2024 14:26
Copy link
Contributor

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can also be changed because keycloak will always be enabled

$jwtUrl = $config->get('keycloak.enabled') ? $config->get('jwt.domain') : null;

@LucWollants
Copy link
Contributor

Maybe prepare a config change that removes all the Auth0-related config? However, we need to wait to merge that cleanup of the config until this code is deployed to production.

@JonasVHG
Copy link
Contributor Author

Maybe prepare a config change that removes all the Auth0-related config? However, we need to wait to merge that cleanup of the config until this code is deployed to production.

Yes, I decided to wait with this task, because as long it is not deployed it cannot be merged. I could also make one with a wait-to-merge-label.

@JonasVHG JonasVHG requested a review from LucWollants November 18, 2024 15:20
@LucWollants
Copy link
Contributor

Yes, I decided to wait with this task, because as long it is not deployed it cannot be merged. I could also make one with a wait-to-merge-label.

I would already make a pull request, so we can put some "pressure" on releasing everything

@JonasVHG JonasVHG merged commit 8564d05 into main Nov 19, 2024
9 checks passed
@JonasVHG JonasVHG deleted the III-6410-remove-auth0 branch November 19, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants