-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
III-6410 Cleanup auth0 Code #328
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can also be changed because keycloak
will always be enabled
$jwtUrl = $config->get('keycloak.enabled') ? $config->get('jwt.domain') : null; |
Maybe prepare a config change that removes all the Auth0-related config? However, we need to wait to merge that cleanup of the config until this code is deployed to production. |
Yes, I decided to wait with this task, because as long it is not deployed it cannot be merged. I could also make one with a |
I would already make a pull request, so we can put some "pressure" on releasing everything |
Changed
app/RoutingServiceProvider
:pemfile
will only be theKeycloak
one &getManagementTokenProvider()
will always be aKeycloak
one.JsonDocumentFetcherProvider
:getTokenGenerator()
will always return aKeycloakTokenGenerator
Authentication/AuthenticateRequest
: rename$auth0Down
to$oAuthServerDown
&$jwtUrl
is always set.AuthenticateRequestTest
: UseKeycloakMetadataGenerator
instead ofAuth0MetadataGenerator
in tests & update MockResponses with Keycloak metadata.Removed
Auth0TokenGenerator
Auth0MetadataGenerator
Related PR
Ticket: https://jira.publiq.be/browse/III-6410