Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

III-5875 Embed contributers to uri #255

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

grubolsch
Copy link
Contributor

Changed

Added embedContributors GET param to URI to fetch document for indexing


Ticket: https://jira.uitdatabank.be/browse/III-5875

@grubolsch
Copy link
Contributor Author

I am aware a unit test is broken, but I think the unit test is actually wrong in how the behavior should be.
The contributers should NOT be included in the originalEncodedJsonLd, because then everybody has access to it.

@LucWollants
Copy link
Contributor

I am aware a unit test is broken, but I think the unit test is actually wrong in how the behavior should be. The contributers should NOT be included in the originalEncodedJsonLd, because then everybody has access to it.

@grubolsch I think your assumption is correct.

@LucWollants
Copy link
Contributor

@grubolsch but I also found this method JsonLdPolyfillJsonTransformer::removeInternalProperties

@grubolsch
Copy link
Contributor Author

All feedback has been processed.

@LucWollants LucWollants merged commit 11c66ac into main Nov 15, 2023
3 checks passed
@LucWollants LucWollants deleted the III-5875/add-embed-contributers-to-uri branch November 15, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants