Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

III-6412 cleanup auth0 code #198

Merged
merged 8 commits into from
Nov 19, 2024
Merged

III-6412 cleanup auth0 code #198

merged 8 commits into from
Nov 19, 2024

Conversation

JonasVHG
Copy link
Contributor

@JonasVHG JonasVHG commented Nov 18, 2024

Changed

  • README.md: Removed info about auth0
  • config.dist.yml: Replace auth0 with keycloak
  • ActionServiceProvider: remove getIdentityProvider() & always use keycloak, when fetching a value from config.
  • Rename LogOutAuth0Adapter to LogOutOAuthAdapter
  • Rename LoginAuth0Adapter to LoginOAuthAdapter
  • Rename RefreshAuth0Adapter to RefreshOAuthAdapter

Related PR


Ticket: https://jira.publiq.be/browse/III-6412

@LucWollants
Copy link
Contributor

I wonder if we should also change the naming of the generic classes like LogOutAuth0Adapter and change them to LogOutOAuthAdapter ?

@JonasVHG
Copy link
Contributor Author

I wonder if we should also change the naming of the generic classes like LogOutAuth0Adapter and change them to LogOutOAuthAdapter ?

Done. But since we still use the auth0-sdk, we'll still have some variable names with auth0

@LucWollants
Copy link
Contributor

I wonder if we should also change the naming of the generic classes like LogOutAuth0Adapter and change them to LogOutOAuthAdapter ?

Done. But since we still use the auth0-sdk, we'll still have some variable names with auth0

That's fine! Who knows, maybe we remove the dependency on that Auth0 SDK in the future.

@JonasVHG JonasVHG merged commit 65795c1 into main Nov 19, 2024
9 checks passed
@JonasVHG JonasVHG deleted the III-6412-cleanup-auth0-code branch November 19, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants