Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken test, introduce pipeline github #145

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Fixed broken test, introduce pipeline github #145

merged 5 commits into from
Apr 22, 2024

Conversation

grubolsch
Copy link
Contributor

@grubolsch grubolsch commented Apr 11, 2024 •
edited
Loading

Added

  • Added pipeline github (phpstan + phpunit) forPHP 7.4
  • Fixed phpstan errors to lvl 5
  • Fixed current unit tests
  • Upgraded phpunit to make tests run

Base automatically changed from uitidv1/rector to uitidv1/modernise-dev-dependencies April 19, 2024 08:24
LucWollants
LucWollants reviewed Apr 19, 2024
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
LucWollants
LucWollants requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@LucWollants LucWollants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The travis.yml file can also be removed.

Base automatically changed from uitidv1/modernise-dev-dependencies to uitidv1/main April 22, 2024 08:55
@grubolsch grubolsch requested a review from LucWollants April 22, 2024 09:00
@grubolsch grubolsch merged commit 1b07d38 into uitidv1/main Apr 22, 2024
2 checks passed
@grubolsch grubolsch deleted the uitidv1/fix-tests-introduce-pipeline branch April 22, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucWollants LucWollants LucWollants approved these changes

@JonasVHG JonasVHG Awaiting requested review from JonasVHG JonasVHG is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grubolsch @LucWollants