Fixed broken test, introduce pipeline github

.github/CODEOWNERS

@@ -0,0 +1,10 @@
+# CODEOWNERS are automatically assigned as possible reviewers to new PRs.
+
+# Global owners (also need to be duplicated in later rules)
+* @LucWollants @JonasVHG @simon-debruijn @grubolsch
+
+# Jenkins / deployment owners
+Gemfile* @willaerk @paulherbosch
+Jenkinsfile* @willaerk @paulherbosch
+Rakefile @willaerk @paulherbosch
+lib/ @willaerk @paulherbosch

.github/workflows/ci.yml

@@ -0,0 +1,75 @@
+name: CI
+
+on: push
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php-versions: ['7.4', '8.0']
+    name: PHP ${{ matrix.php-versions }}
+    steps:
+      - name: 📤 Checkout project
+        uses: actions/checkout@v2
+
+      - name: 🐘 Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-versions }}
+          ini-values: xdebug.mode=coverage
+          tools: composer
+
+      - name: ✌️ Check PHP Version
+        run: php -v
+
+      - name: 🛂 Validate composer.json and composer.lock
+        run: composer validate
+
+      - name: 📩 Cache Composer packages
+        id: composer-cache
+        uses: actions/cache@v2
+        with:
+          path: vendor
+          key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-php-
+
+      - name: 📦 Install dependencies
+        if: steps.composer-cache.outputs.cache-hit != 'true'
+        run: composer install --no-progress --no-suggest
+
+      - name: ✅ Run tests
+        run: composer test
+
+  phpstan:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php-versions: [ '7.4', '8.0' ]
+    name: Static analysis (PHP ${{ matrix.php-versions }})
+    steps:
+      - name: 📤 Checkout project
+        uses: actions/checkout@v2
+
+      - name: 🐘 Install PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php-versions }}
+          tools: composer
+
+      - name: 📩 Cache Composer packages
+        id: composer-cache
+        uses: actions/cache@v2
+        with:
+          path: vendor
+          key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-php-
+
+      - name: 📦 Install dependencies
+        if: steps.composer-cache.outputs.cache-hit != 'true'
+        run: composer install --no-progress --no-suggest
+
+      - name: 🔍 Run static analysis
+        run: composer phpstan

app/BaseServiceProvider.php

@@ -9,12 +9,8 @@ abstract class BaseServiceProvider extends AbstractServiceProvider
 {
     /**
      * Add Service definition to container
-     *
-     * @param string $serviceName
-     * @param $function
-     * @param string|null $tag
      */
-    protected function add(string $serviceName, $function, ?string $tag = null): void
+    protected function add(string $serviceName, callable $function, ?string $tag = null): void
     {
         $definition = $this->getLeagueContainer()
             ->add($serviceName, $function);
@@ -26,12 +22,8 @@ protected function add(string $serviceName, $function, ?string $tag = null): voi
 
     /**
      * Add Service definition to container
-     *
-     * @param string $serviceName
-     * @param $function
-     * @param string|null $tag
      */
-    protected function addShared(string $serviceName, $function, ?string $tag = null): void
+    protected function addShared(string $serviceName, callable $function, ?string $tag = null): void
     {
         $definition = $this->getLeagueContainer()
             ->share($serviceName, $function);
@@ -44,7 +36,6 @@ protected function addShared(string $serviceName, $function, ?string $tag = null
     /**
      * Get parameter from config
      *
-     * @param string $parameter
      * @return mixed
      */
     protected function parameter(string $parameter)
@@ -55,7 +46,6 @@ protected function parameter(string $parameter)
     /**
      * Get service from container
      *
-     * @param string $name
      * @return mixed
      */
     protected function get(string $name)

app/Console/DecodeJwtCommand.php

@@ -2,7 +2,7 @@
 
 namespace CultuurNet\UDB3\JwtProvider\Console;
 
-use CultuurNet\UDB3\Jwt\JWTDecoderServiceInterface;
+use CultuurNet\UDB3\Jwt\JwtDecoderServiceInterface;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -11,9 +11,9 @@
 
 class DecodeJwtCommand extends Command
 {
-    private JWTDecoderServiceInterface $decoder;
+    private JwtDecoderServiceInterface $decoder;
 
-    public function __construct(JWTDecoderServiceInterface $decoder)
+    public function __construct(JwtDecoderServiceInterface $decoder)
     {
         parent::__construct();
         $this->decoder = $decoder;
@@ -50,6 +50,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $output->writeln('Signature verification: ' . ($verified ? '✓' : '✕'));
 
         // Return 0 as exit code if verified & valid, otherwise 1.
-        return !($valid && $verified);
+        return ($valid && $verified) ? 1 : 0;
     }
 }

composer.json

@@ -23,12 +23,12 @@
         "zendframework/zend-httphandlerrunner": "^1.1"
     },
     "require-dev": {
-        "phpunit/phpunit": "^7.5",
         "escapestudios/symfony2-coding-standard": "~2.9",
         "squizlabs/php_codesniffer": "~2.5.1",
         "satooshi/php-coveralls": "^2.1",
         "phpstan/phpstan": "^1.10",
-        "rector/rector": "^1.0"
+        "rector/rector": "^1.0",
+        "phpunit/phpunit": "^9.6"
     },
     "autoload": {
         "psr-4": {