Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure cram builder supports spec-relative module ids #142

Closed
briancavalier opened this issue Nov 10, 2013 · 3 comments
Closed

Ensure cram builder supports spec-relative module ids #142

briancavalier opened this issue Nov 10, 2013 · 3 comments
Assignees
@briancavalier
Milestone
0.10.4

Comments

@briancavalier
Copy link
Member

See #131 and #140, specifically @gehan's initial test results. We need to make sure we support the same relative id strategy in cram as well before we release 0.10.3.
@briancavalier
Copy link
Member Author

It may be as simple as ensuring that addDep and addSpec apply the id normalization transform, just as wire does when running outside of cram.

@briancavalier briancavalier mentioned this issue Nov 20, 2013
Closed
@ghost ghost assigned briancavalier Nov 21, 2013
briancavalier added a commit that referenced this issue Nov 21, 2013
@briancavalier
Add relative module/plugin/resource id support to cram builder plugin. …
13f39ab 
…Fix #142
@briancavalier
Copy link
Member Author

Ping @gehan :) This will be released in 0.10.4

@gehan
Copy link

gehan commented Nov 21, 2013

Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@briancavalier briancavalier

Labels
None yet
Projects
None yet
Milestone
0.10.4
Development

No branches or pull requests
2 participants
@briancavalier @gehan