This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
Prefers-color-scheme Fix #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had an issue where on some browsers, many elements wouldn't appear. This was because when we used prefers-color-scheme, we were checking for both light and dark themes specifically. If a device didn't support it, then neither would be chosen. The solution was to only use prefers-color-scheme when checking for a dark theme, and providing the light theme as default.
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/cuhacking/cuhacking-website/o2btnof1y |
MrNickCasey
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where on some browsers, many elements wouldn't appear.
This was because when we used prefers-color-scheme, we were checking for
both light and dark themes specifically. If a device didn't support it,
then neither would be chosen.
The solution was to only use prefers-color-scheme when checking for a
dark theme, and providing the light theme as default.