Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: Tag polyglot go releases with go/vVERSION #93

Merged
merged 1 commit into from
Dec 27, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Dec 27, 2022

https://go.dev/ref/mod#vcs-version
If a module is defined in a subdirectory within the repository, that is, the
module subdirectory portion of the module path is not empty, then each tag
name must be prefixed with the module subdirectory, followed by a slash. For
example, the module golang.org/x/tools/gopls is defined in the gopls
subdirectory of the repository with root path golang.org/x/tools. The
version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
repository.

Currently, releases are only tagged with vVERSION. So to make go happy we have to add a go/vVERSION tag.

Fixes: #91

@mpkorstanje mpkorstanje force-pushed the go-tag-polyglot-releases-with-go-version branch 3 times, most recently from a8e13d4 to 1d41ce7 Compare December 27, 2022 14:07
> https://go.dev/ref/mod#vcs-version
> If a module is defined in a subdirectory within the repository, that is, the
> module subdirectory portion of the module path is not empty, then each tag
> name must be prefixed with the module subdirectory, followed by a slash. For
> example, the module golang.org/x/tools/gopls is defined in the gopls
> subdirectory of the repository with root path golang.org/x/tools. The
> version v0.4.0 of that module must have the tag named gopls/v0.4.0 in that
> repository.

Currently, releases are only tagged with `vVERSION`. So to make go happy we
have to add a `go/vVERSION` tag.

Fixes: #91
@mpkorstanje mpkorstanje force-pushed the go-tag-polyglot-releases-with-go-version branch from 1d41ce7 to bd0e292 Compare December 27, 2022 14:16
@mpkorstanje mpkorstanje merged commit 828cf28 into main Dec 27, 2022
@mpkorstanje mpkorstanje deleted the go-tag-polyglot-releases-with-go-version branch December 27, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go: Tag releases with go/vVERSION
1 participant