Moved simplecov_setup into lib folder #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As simplecov_setup is a runtime dependency of the cucumber bin script it should not be placed into spec/ folder as there should be only test parts be placed. The old code bites us at SUSE as all tests are split into a testsuite package which results in a currently broken cucumber.
|
related to the discussion in 4b8343a |
|
Build failed just because of coveralls API error. |
mattwynne
added a commit
that referenced
this pull request
Aug 7, 2015
Moved simplecov_setup into lib folder
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As simplecov_setup is a runtime dependency of the cucumber bin script it
should not be placed into spec/ folder as there should be only test
parts be placed. The old code bites us at SUSE as all tests are split
into a testsuite package which results in a currently broken cucumber.