[Core] Support nested jar file systems #2830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
mpkorstanje
force-pushed
the
support-nested-jars
branch
from
12a014b to
84dfe17
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2830 +/- ##
============================================
+ Coverage 84.95% 84.97% +0.01%
- Complexity 2724 2728 +4
============================================
Files 331 331
Lines 9539 9545 +6
Branches 916 917 +1
============================================
+ Hits 8104 8111 +7
+ Misses 1110 1109 -1
Partials 325 325 ☔ View full report in Codecov by Sentry. |
Spring Boot 3.2 changed the URL format of their nested jars[1] to be more compliant with JDK expectations. They now represented nested jars as their own `nested` scheme rather than the `file` scheme. This allows these URLs to be used seamlessly with `FileSystems.newFileSystem`. Unfortunately the workarounds for Spring Boot 3.1 did not account for this. Additionally, our jar uri parsing assumed naively that there would only be a single `!/` in a regular jar uri. However, jar uris are recursively defined as[2]: ``` jar:<url>!/[<entry>] ``` And while this should allow Cucumber to discover resources in nested jars as well it does seem that Spring Boot 3.2 still has some issues[3]. Closes: #2828 1. https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.2-Release-Notes 2. https://www.iana.org/assignments/uri-schemes/prov/jar 3. spring-projects/spring-boot#38595
mpkorstanje
force-pushed
the
support-nested-jars
branch
from
84dfe17 to
bea8cca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Spring Boot 3.2 changed the URL format of their nested jars[1] to be more compliant with JDK expectations. They now represented nested jars as their own
nestedscheme rather than thefilescheme. This allows these URLs to be used seamlessly withFileSystems.newFileSystem.Unfortunately the workarounds for Spring Boot 3.1 did not account for this.
Additionally, our jar uri parsing assumed naively that there would only be a single
!/in a regular jar uri. However, jar uris are recursively defined as[2]:And while this should allow Cucumber to discover resources in nested jars as well it does seem that Spring Boot 3.2 still has some issues[3].
Closes: #2828
🏷️ What kind of change is this?
📋 Checklist: