-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JUnit Platform] Support feature files with space in filename #2521
Conversation
…aracter Exception * Add a file with a space in test cases. * Replace URI.getSchemeSpecificPart by URI.getRawSchemeSpecificPart to keep space encoded.
Looks good but could you add a test and update the changelog? Something like this should do: Lines 73 to 79 in 5853a06
|
…aracter Exception * Add a test * Update test file (with space.feature) with a test (not just an empty feature) * Update others tests (there is a new feature file, so other test should expect one file more) * Update CHANGELOG.md
Hi, I had'nt add test because all the tests crashed with the new Adding a test as you asked make me add a scenario in the
|
Codecov Report
@@ Coverage Diff @@
## main #2521 +/- ##
=========================================
Coverage 83.80% 83.80%
Complexity 2651 2651
=========================================
Files 309 309
Lines 9360 9360
Branches 913 913
=========================================
Hits 7844 7844
Misses 1183 1183
Partials 333 333
Continue to review full report at Codecov.
|
Hi @lgringo, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Cheers! |
🤔 What's changed?
keep space encoded.
⚡️ What's your motivation?
Fixes #2520
🏷️ What kind of change is this?
📋 Checklist: