[Core] Pretty formatter to print step DataTables

[artysidorenko]

Is your pull request related to a problem? Please describe.

• relates to issue Including DataTables in pretty-plugin terminal output #2320

Describe the solution you have implemented

• updates PrettyFormatter.printStep to process the DataTable if one is present in the step object
• uses DataTableFormatter exposed in cucumber-common v4 / this PR

Additional context

• at the moment just figuring out a broken StepExpressionFactoryTest that's popped up elsewhere in the core module while QA testing (appears to be from bumping common to v4)
• opened up the PR as a draft in the meantime, in case of feedback/a different approach is needed

[mpkorstanje]

I didnt' get any notification because you've marked the PR as a Draft. It does mostly look ready to me. Do you have anything to add?

[mpkorstanje]

Btw, because the datatable changes from v3 to v4 this has to go into Cucumber v7. Could you rebase your branch on top of the v7.x.x branch? You can drop any commits that weren't made by you.

[codecov]

Codecov Report

Merging #2330 (d7143ce) into v7.x.x (1be1b52) will increase coverage by 0.01%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##             v7.x.x    #2330      +/-   ##
============================================
+ Coverage     83.12%   83.14%   +0.01%     
- Complexity     2292     2295       +3     
============================================
  Files           292      292              
  Lines          8251     8270      +19     
  Branches        738      739       +1     
============================================
+ Hits           6859     6876      +17     
- Misses         1103     1105       +2     
  Partials        289      289              

Impacted Files	Coverage Δ
.../java/io/cucumber/core/plugin/PrettyFormatter.java	84.55% <81.81%> (-0.25%)	⬇️
...ucumber/core/options/CucumberPropertiesParser.java	95.65% <0.00%> (+0.06%)	⬆️
.../java/io/cucumber/testng/TestNGCucumberRunner.java	96.55% <0.00%> (+0.32%)	⬆️
...o/cucumber/testng/AbstractTestNGCucumberTests.java	71.42% <0.00%> (+4.76%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be1b52...d7143ce. Read the comment docs.

[artysidorenko]

I didnt' get any notification because you've marked the PR as a Draft. It does mostly look ready to me. Do you have anything to add?

Ah right - apologies for the duplicated work. I didn't have anything to add, but had been planning to QA test - building it locally and importing into my other project to see in-real-life if it was working as expected. Unfortunately I had some other work things come up that got me side-tracked.

Just rebased on v7.x.x (which removed a bunch of now-empty commits). Will try to get it running locally this weekend, but marked as ready-to-review in any case as I wasn't expecting any code changes.

[mpkorstanje]

Wrong button.

[artysidorenko]

Managed to try it out locally on my other project - looks as I had expected/hoped :)

[mpkorstanje]

Cheers!