Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove cucumber.options property #1958

Merged
merged 6 commits into from
Apr 23, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Apr 23, 2020

cucumber.options was used to control cucumbers execution when run through mvn test. This is no longer required with the introduction of property based runtime options in #1741. Removing cucumber.options allows CLI argument parsing to be separated from property parsing which simplifies the complexity of parsing significantly.

Additionally

  • We remove --add-plugin and associated logic in RuntimeOptionsBuilder. All plugins are added by default.
  • Separate calling System.exit from parsing the runtime options. Main should check if exit is required after parsing.
  • Write tests that validate if the correct text is written to System.out and System.err by injecting these into CommandlineOptionsParser.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Todo

  • Check doc.cucumber.io for usages of cucumber.options.

@mpkorstanje mpkorstanje changed the base branch from master to v6.x.x April 23, 2020 16:19
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 86.583% when pulling e9c3117 on core-remove-cucumber-options into 5b73489 on v6.x.x.

@mpkorstanje mpkorstanje added this to the 6.0.0 milestone Apr 23, 2020
@mpkorstanje mpkorstanje merged commit 839dba7 into v6.x.x Apr 23, 2020
@mpkorstanje mpkorstanje deleted the core-remove-cucumber-options branch April 23, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants