[Core] Remove cucumber.options
property
#1958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cucumber.options
was used to control cucumbers execution when run throughmvn test
. This is no longer required with the introduction of property based runtime options in #1741. Removingcucumber.options
allows CLI argument parsing to be separated from property parsing which simplifies the complexity of parsing significantly.Additionally
--add-plugin
and associated logic inRuntimeOptionsBuilder
. All plugins are added by default.System.exit
from parsing the runtime options. Main should check if exit is required after parsing.System.out
andSystem.err
by injecting these intoCommandlineOptionsParser
.Types of changes
Checklist:
Todo
doc.cucumber.io
for usages ofcucumber.options
.