Exclude Multi-Release files from Jackson while shading (#2793)

Cucumber-JVM uses Jackson Databind to write json. Because Jackson is a very common dependency, to ensure we do not interfere with the system under test, we shade it. Unfortunately the Shade plugin occasionally gets updates and now includes multi-releases. These were not included in the relocation pattern and result in duplicate classes when Cucumber itself is shaded. As `cucumber-core` is not a multi-release jar, we can exclude the multi- release files altogether. Fixes: #2786
cucumber · Sep 9, 2023 · 3165714 · 3165714
1 parent b0a4373
commit 3165714
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- [Core] Exclude Multi-Release files from Jackson while shading ([#2786](https://github.com/cucumber/cucumber-jvm/pull/2786) M.P. Korstanje)
+
 ## [7.13.0] - 2023-07-02
 ### Changed
 - [TestNG] Update dependency org.testng:testng to v7.8.0

diff --git a/cucumber-core/pom.xml b/cucumber-core/pom.xml
@@ -232,6 +232,12 @@
                             <goal>shade</goal>
                         </goals>
                         <configuration>
+                            <transformers>
+                                <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer"/>
+                                <transformer implementation="org.apache.maven.plugins.shade.resource.ApacheNoticeResourceTransformer">
+                                    <addHeader>false</addHeader>
+                                </transformer>
+                            </transformers>
                             <artifactSet>
                                 <includes>
                                     <include>com.fasterxml.jackson.core:jackson-databind</include>
@@ -253,35 +259,31 @@
                                         <exclude>**/module-info.class</exclude>
                                         <exclude>**/module-info.class</exclude>
                                         <exclude>META-INF/MANIFEST.MF</exclude>
-                                        <exclude>META-INF/LICENSE</exclude>
-                                        <exclude>META-INF/NOTICE</exclude>
                                         <exclude>META-INF/services/**</exclude>
+                                        <exclude>META-INF/versions/**</exclude>
                                     </excludes>
                                 </filter>
                                 <filter>
                                     <artifact>com.fasterxml.jackson.core:jackson-core</artifact>
                                     <excludes>
                                         <exclude>**/module-info.class</exclude>
                                         <exclude>META-INF/MANIFEST.MF</exclude>
-                                        <exclude>META-INF/LICENSE</exclude>
-                                        <exclude>META-INF/NOTICE</exclude>
                                         <exclude>META-INF/services/**</exclude>
+                                        <exclude>META-INF/versions/**</exclude>
                                     </excludes>
                                 </filter>
                                 <filter>
                                     <artifact>com.fasterxml.jackson.core:jackson-annotations</artifact>
                                     <excludes>
                                         <exclude>**/module-info.class</exclude>
                                         <exclude>META-INF/MANIFEST.MF</exclude>
-                                        <exclude>META-INF/LICENSE</exclude>
                                     </excludes>
                                 </filter>
                                 <filter>
                                     <artifact>com.fasterxml.jackson.datatype:jackson-datatype-jdk8</artifact>
                                     <excludes>
                                         <exclude>**/module-info.class</exclude>
                                         <exclude>META-INF/MANIFEST.MF</exclude>
-                                        <exclude>META-INF/LICENSE</exclude>
                                         <exclude>META-INF/services/**</exclude>
                                     </excludes>
                                 </filter>