Convert step duration from ms to ns for JSON Formatter

[gpichot]

Unless I miss something, the duration should not be in milliseconds in the JSON reporter but in nanoseconds. I checked and the Gherkin JSON report format uses nanoseconds. See:

• https://github.com/cucumber/gherkin2/blob/master/lib/gherkin/formatter/json_formatter.rb#L69

It could help on our side as our CI Cucumber reporter expect nanoseconds and not milliseconds.

[charlierudolph]

You are pointing to a deprecated project to show that the json formatter should be in nanoseconds. Are you suggesting that this should be nanoseconds to line up with cucumber-ruby?

With the 2.0 release candidate, we switched from storing nanoseconds to storing milliseconds to simplify the implementation so the same code runs both in the browser and on node. Yes we can convert the json formatter to ouput nanoseconds but since we aren't currently saving that level of precision that seems wrong to me.

[gpichot]

@charlierudolph Indeed, I didn't saw that it was deprecated.

Then I am not clear with the current unit used for Cucumber reports in the JSON formatter. Are they different units for the duration depending on the runtime?

If it's milliseconds in cucumber-ruby & cucumber-jvm indeed it makes sense to respect this format in cucumber-js too. But it seems like the unit is nanoseconds in cucumber-jvm and cucumber-ruby:

• https://github.com/cucumber/cucumber-ruby/blob/0161920e5dde15161d74091ffb3ac04aef0b1938/lib/cucumber/formatter/json.rb#L209
• https://github.com/cucumber/cucumber-jvm/blob/45ee6743517968ee086f674f941334660bdc4f82/core/src/main/java/cucumber/runtime/Runtime.java#L307

From my perspective, I would rather have the duration unit be the same in all reports no matter the cucumber runtime used.

My point is just that CI report generators are making assumptions about the format of the JSON report. But if it's by design, we will find another way to feed them to the report generator.

[gpichot]

@charlierudolph Just a quick note: we now use this fix to generate the json reports. The Jenkins reporter that we use now outputs the correct durations.

=> Feel free to close this one if it does not comply with the specification that you have chosen. I was just puzzled by the fact that you choose to break JSON report compatibility between cucumber implementations.

[charlierudolph]

Created cucumber/common#187 to start a discussion about a shared JSON schema that all cucumber implementations could follow. Going to close this for now

[gpichot]

@charlierudolph Thanks!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.