Add error diffs to pretty formatter #421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes I believe we want an ErrorPresenter object as the summary formatter will definitely want this when it displays errors and we may want to work this into the json formatter as well |
|
Hi folks. This is exactly what I'm looking for. Is there a way to override FailedStepResult somehow externally, probably with some hooks? I'm using cucumber.js with protractor and gulp/grunt. |
|
can I help to get this moving forward? :) |
|
+1 from me, will try to code it if i ever find any time! |
|
Closing this as I working on this in another branch and just taking a bunch of code from mocha. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge.
This is an experimental attempt at fixing #386. Something similar would be implemented in a more global fashion. The key idea being that we check for the three properties
showDiff,expectedandactualproperties on error instances to return an augmented description of it. It should probably done in a new ErrorPresenter object, rather than on FailedStepResult.Thoughts?