Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further examples for valid Cucumber files to pretty-print #2024

Closed
wants to merge 1 commit into from

Conversation

jamietanna
Copy link
Contributor

Summary

Following up on the changes for cucumber/gherkin-utils#4, via #1725 and #1985, we're still missing some key areas of improvement for pretty-printing, in which I'd be hesitant to recommend folks use this until they're resolved - or at least we better document what "expected" behaviour is.

Details

Motivation and Context

See above summary.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@jamietanna
Copy link
Contributor Author

CC @nddipiazza @aslakhellesoy

@jamietanna
Copy link
Contributor Author

jamietanna commented Jun 26, 2022

Just raising this for visibility, be great if either of you / someone else fancies picking this up 🙏

@mattwynne
Copy link
Member

@jamietanna thanks for this contribution! We're migrating the code for gherkin-utils into a separate repo (https://github.com/cucumber/gherkin-utils)

Would you mind making this same PR against that repo? I don't think I have the power to transfer it for you unfortunately.

@blacelle
Copy link

blacelle commented Apr 2, 2023

@jamietanna Should this be moved into gherkin-utils ? As this will be integrated into Spotless, some additional users would encounter these limitations.

@jamietanna
Copy link
Contributor Author

Yes, feel free to - I'm unfortunately not going to be able to get round to this - happy to share some more examples from my library that may be of interest, where there's a few more of the complex examples that we should handle

@blacelle
Copy link

blacelle commented Apr 2, 2023

Done in cucumber/gherkin-utils#20

I may have a look if you have other specific broken cases.

@luke-hill luke-hill closed this Aug 15, 2023
@luke-hill luke-hill deleted the defect/pretty-cucumber branch August 15, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants