Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix(cubesql): Make cube join check stricter #9043

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Now it should catch plans like Join(CubeScan, Projection(CubeScan))

@mcheshkov mcheshkov force-pushed the stricter-cube-join-check branch from 3297d5d to 23dc3be Compare February 18, 2025 14:36
Now it should disallow any plans with ungrouped CubeScan inside, like Join(CubeScan, Projection(CubeScan(ungrouped=true)))
@mcheshkov mcheshkov force-pushed the stricter-cube-join-check branch from 23dc3be to 96574fb Compare February 18, 2025 14:41
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 42.64706% with 39 lines in your changes missing coverage. Please review.

Project coverage is 83.40%. Comparing base (84f90c0) to head (96574fb).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 0.00% 27 Missing ⚠️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 69.23% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9043      +/-   ##
==========================================
- Coverage   83.57%   83.40%   -0.18%     
==========================================
  Files         227      227              
  Lines       81627    81670      +43     
==========================================
- Hits        68216    68113     -103     
- Misses      13411    13557     +146     
Flag Coverage Δ
cubesql 83.40% <42.64%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant