fix(snowflake): fixing the snowflake schema fetcher logic (#7440) #8665
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
github-actions
bot
added
the
pr:community
christianallred-nomi
force-pushed
the
fix(snowflake)fixing-undefined-case-in-snowflake
branch
2 times, most recently
from
85d3857
to
528129e
Compare
christianallred-nomi
force-pushed
the
fix(snowflake)fixing-undefined-case-in-snowflake
branch
from
528129e
to
e6f81bb
Compare
|
Thanks for your contribution! Do you think this is a breaking change? |
|
It should not be no. A while ago snowflake made a decision to always cap case their responses. This caused an Outage for us. And is what causes the bug this or is aiming to fix with cube. The fact that this is working for some snowflake users means they have this setting set globally instead of by session. I liked this solution because it fixes the problem for affected users but should leave the existing users the same. I have not had time to test this 100% however so if someone with a working snowflake instance can test it, that would be great: |
|
An alternate decision that would not require a session update would be to update the snowflake driver to overwrite the result parser function |
|
@christianallred Thanks for contributing it! I think it's definitely great feature however as of now it should go under the flag which we'd enable by default going forward. |
Whatever y'all decide is fine. It’s just broken for our use case until a fix is decided on. FWIW I don’t really have skin in the game anymore as I am leaving the org that was looking at cube as a solution. Cheers :) |
|
@paveltiunov any info about this? I'm having issue with the undefined in snowflake |
|
@mattssll We're open for this change if it'd land under the flag. If you have capacity to fix PR we'd be happy to merge it. |
Check List
Issue Reference this PR resolves
[For example #12]
Description of Changes Made (if issue reference is not provided)
[Description goes here]