Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesqlplanner): Base filters support #8647

Open
wants to merge 1 commit into
base: sql-planner-dimension-support
Choose a base branch
from

Conversation

waralexrom
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Aug 28, 2024 1:31pm
examples-react-d3 ⬜️ Ignored (Inspect) Aug 28, 2024 1:31pm
examples-react-material-ui ⬜️ Ignored (Inspect) Aug 28, 2024 1:31pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Aug 28, 2024 1:31pm

@waralexrom waralexrom requested review from a team as code owners August 28, 2024 13:30
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.50%. Comparing base (01a52a7) to head (aa2c4a1).

Additional details and impacted files
@@                        Coverage Diff                        @@
##           sql-planner-dimension-support    #8647      +/-   ##
=================================================================
- Coverage                          82.53%   82.50%   -0.03%     
=================================================================
  Files                                209      200       -9     
  Lines                              76688    76430     -258     
=================================================================
- Hits                               63292    63060     -232     
+ Misses                             13396    13370      -26     
Flag Coverage Δ
cubesql 82.50% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant